Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 22, 2024

This PR is basically similar to #10048 and removes the remaining sync functions that have an async counterpart.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 22, 2024
@Turbo87 Turbo87 enabled auto-merge November 22, 2024 10:48
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (c49bf69) to head (8e05edd).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/crates-admin/delete_crate.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10054      +/-   ##
==========================================
+ Coverage   89.35%   89.51%   +0.16%     
==========================================
  Files         295      295              
  Lines       31277    31215      -62     
==========================================
- Hits        27946    27943       -3     
+ Misses       3331     3272      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 merged commit bd29578 into rust-lang:main Nov 22, 2024
10 checks passed
@Turbo87 Turbo87 deleted the remove-sync-fns branch November 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant